supervisor issueshttps://gitlab.nic.cz/turris/updater/supervisor/-/issues2022-10-20T23:36:38+02:00https://gitlab.nic.cz/turris/updater/supervisor/-/issues/33AttributeError: 'list' object has no attribute 'splitlines'2022-10-20T23:36:38+02:00Josef SchlehoferAttributeError: 'list' object has no attribute 'splitlines'On my work router Turris 1.1, I was using branch HBL, but I switched to one of our internal branches and I noticed this error:
```
Jul 13 13:50:25 turris updater[7091]: src/pkgupdate/main.c:151 (main):
inconsistent: Requested package s...On my work router Turris 1.1, I was using branch HBL, but I switched to one of our internal branches and I noticed this error:
```
Jul 13 13:50:25 turris updater[7091]: src/pkgupdate/main.c:151 (main):
inconsistent: Requested package strace that is not available.
Jul 13 13:50:25 turris updater-supervisor: pkgupdate exited with: 1
Jul 13 13:50:25 turris updater-supervisor: Traceback (most recent call last):
File "/usr/bin/updater-supervisor", line 33, in <module>
sys.exit(load_entry_point('svupdater==1.5.2', 'console_scripts', 'updater-supervisor')())
File "/usr/lib/python3.9/site-packages/svupdater/__main__.py", line 104, in main
File "/usr/lib/python3.9/site-packages/svupdater/_supervisor.py", line 143, in run
File "/usr/lib/python3.9/site-packages/svupdater/notify.py", line 114, in changes
AttributeError: 'list' object has no attribute 'splitlines'
```https://gitlab.nic.cz/turris/updater/supervisor/-/issues/30Introduce the up to date Python conventions2022-02-15T13:17:55+01:00Karel KociIntroduce the up to date Python conventionsThe code of supervisor at the moment is partially really stuck in Python 2.7 world. That is for example that path constants are strings and not `pathlib.Path` objects. We should also really format the code using black and 120 columns as ...The code of supervisor at the moment is partially really stuck in Python 2.7 world. That is for example that path constants are strings and not `pathlib.Path` objects. We should also really format the code using black and 120 columns as well as to use typing (mypy). There is no reason why we can't have that in this project.https://gitlab.nic.cz/turris/updater/supervisor/-/issues/29Implement some tests2022-02-14T14:06:52+01:00Karel KociImplement some testsThe supervisor is no longer just something that starts and monitors the updater. There is now a lot of parsing and other complex code that we should be testing for sure.The supervisor is no longer just something that starts and monitors the updater. There is now a lot of parsing and other complex code that we should be testing for sure.https://gitlab.nic.cz/turris/updater/supervisor/-/issues/28Reduce size of the changelog if it goes over the some limit2022-06-06T13:54:57+02:00Karel KociReduce size of the changelog if it goes over the some limitRight now we only append to the changelog file. We should also in some cases reduce its size. The reduction should be always done by whole transactions and should not interfere with any running updater or supervisor process.
The interfe...Right now we only append to the changelog file. We should also in some cases reduce its size. The reduction should be always done by whole transactions and should not interfere with any running updater or supervisor process.
The interference is in general an issue as we have to shift the content of the file down to truncate it. We should just introduce file lock to all parties and use that instead.https://gitlab.nic.cz/turris/updater/supervisor/-/issues/25Unify format of notifications2021-06-09T14:11:38+02:00Vojtech MyslivecUnify format of notificationsUnify format and appearance of Turris notifications with the changelog:
![Screenshot_from_2021-05-31_22-17-41](/uploads/578591f6790f6a241c311aabe70fbd3a/Screenshot_from_2021-05-31_22-17-41.png)Unify format and appearance of Turris notifications with the changelog:
![Screenshot_from_2021-05-31_22-17-41](/uploads/578591f6790f6a241c311aabe70fbd3a/Screenshot_from_2021-05-31_22-17-41.png)https://gitlab.nic.cz/turris/updater/supervisor/-/issues/24Handle occasional error notification2023-05-30T14:37:50+02:00Vojtech MyslivecHandle occasional error notificationTurris Updater runs 6 times a day. Sometimes for various reasons, an updater is not able to finish package cache update or similar operations.
This error leads to an error notifications all-the-time, which can be confusing and annoying....Turris Updater runs 6 times a day. Sometimes for various reasons, an updater is not able to finish package cache update or similar operations.
This error leads to an error notifications all-the-time, which can be confusing and annoying. In fact, no big deal happens as the updater finishes its job next time (in a few hours).
We should handle these error notifications and send them only e.g. after all day without a successful update check. This would mitigate most of the false negative notifications for end users.https://gitlab.nic.cz/turris/updater/supervisor/-/issues/11Support for notification system2019-11-27T12:42:16+01:00Karel KociSupport for notification systemWe should support notification system or at least not fail when notification system is installed.
Currently we faul with:
```
Nov 27 11:20:28 work-mox updater-supervisor: Traceback (most recent call last):
File "/usr/bin/updater-supe...We should support notification system or at least not fail when notification system is installed.
Currently we faul with:
```
Nov 27 11:20:28 work-mox updater-supervisor: Traceback (most recent call last):
File "/usr/bin/updater-supervisor", line 11, in <module>
load_entry_point('svupdater==1.2.1', 'console_scripts', 'updater-supervisor')()
File "/__main__.py", line 103, in main
File "/_supervisor.py", line 177, in run
File "/notify.py", line 135, in notifier
File "/subprocess.py", line 339, in call
File "/subprocess.py", line 800, in __init__
File "/subprocess.py", line 1551, in _execute_child
FileNotFoundError: [Errno 2] No such file or directory: 'notifier': 'notifier'
```https://gitlab.nic.cz/turris/updater/supervisor/-/issues/3Document how approvals work and overall what files updater uses and their format2019-07-08T11:01:46+02:00Karel KociDocument how approvals work and overall what files updater uses and their formatWe are currently generating few files in `/usr/share/updater` and almost not of those has format well defined and if they have then their real function is not documented. We should fix that.We are currently generating few files in `/usr/share/updater` and almost not of those has format well defined and if they have then their real function is not documented. We should fix that.https://gitlab.nic.cz/turris/updater/supervisor/-/issues/1Automatically approve fixup releases2022-06-06T14:34:36+02:00Karel KociAutomatically approve fixup releasesFixup releases are mostly harmless and some users wishes to have them installed
automatically but requests minor and major releases to be approved.Fixup releases are mostly harmless and some users wishes to have them installed
automatically but requests minor and major releases to be approved.