• Engling, Uwe's avatar
    jffs2: ECC corrected nand data is ignored · 41ba7f52
    Engling, Uwe authored
    Hello,
    
    I ran into a problem with the JFFS2 filesystem driver implemented in U-Boot.
    
    I've got a NAND device that has correctable ECC errors (corrected somewhere in mtd/nand/nand_base.c).
    The NAND driver tells the filesystem layer (jffs2_1pass.c) above that there occurred correctable ECC errors and returns with a "value > 0".
    The JFFS2 driver recognizes the corrected ECC errors as real error and skips this block because the only accepts a "return value == 0" as correct.
    
    This problem exists for over 8 years (I checked version 2010.09) so I'm a little bit worried that I interpreted something wrong or didn't get the whole context.
    
    Can someone confirm this bug (and the bugfix) in the u-boot jffs2 driver?
    
    There was a mail in 2012 that mentioned the same problem, but there was no patch:
    http://u-boot.10912.n7.nabble.com/JFFS2-seems-to-drop-nand-data-with-ECC-corrections-td142008.html
    Sometime after this discussion the return value of nand_read() changed from -EUCLEAN as correctable ECC error to a positive value with the count of ECC corrected errors.
    
    With kind reguards,
    Uwe Engling
    41ba7f52