Use samba4 instead of samba3
In PR !28 (merged), I noticed some changes regarding samba.
Shouldn't we use samba4 instead of samba(3)? The only issue what I am thinking is that samba4 is not available in OpenWrt 18.06.
In 19.07 or master is included. I asked in #openwrt-devel why samba3 is still present in OpenWrt
20:13:11 <Pepe> I am wondering why in the master branch, there is still samba3, which was EOL 4 years ago. 20:31:18 <pkgadd> Pepe: because samba4 is unsuitable for most devices 22:45:51 <mangix> Pepe: size 22:45:56 <mangix> and laziness 22:47:07 <mangix> It should be removed from the main branch
We have powerful routers with a large amount of space, so it shouldn't be an issue to have supported version of samba4 or am I wrong? It depends how much we are going to diverge from OpenWrt. On the other hand, I am against it, but samba3 is vulnerable and reached EoL a long time ago. This should be handled directly in OpenWrt, they should decide what they are going to do with samba3, because this ancient version is not even in Debian.