Nest: Neighbor cache cleanups

Simplify neighbor cache code, fix several minor bugs, and improve
handling of ONLINK flag.
32 jobs for <span class="ref-name">int-new</span> in 4 minutes and 44 seconds (queued for 3 seconds)
Status Job ID Name Coverage
  Image
passed #147272
dind allowed to fail
docker_centos-6-amd64

00:00:30

passed #147273
dind allowed to fail
docker_centos-7-amd64

00:00:24

passed #147262
dind allowed to fail
docker_debian-7-amd64

00:00:26

passed #147266
dind allowed to fail
docker_debian-7-i386

00:00:28

passed #147263
dind allowed to fail
docker_debian-8-amd64

00:00:25

passed #147267
dind allowed to fail
docker_debian-8-i386

00:00:24

passed #147264
dind allowed to fail
docker_debian-9-amd64

00:00:24

passed #147268
dind allowed to fail
docker_debian-9-i386

00:00:24

passed #147265
dind allowed to fail
docker_debian-testing-amd64

00:00:21

passed #147269
dind allowed to fail
docker_debian-testing-i386

00:00:26

passed #147270
dind allowed to fail
docker_fedora-25-amd64

00:00:25

passed #147271
dind allowed to fail
docker_fedora-26-amd64

00:00:27

passed #147274
dind allowed to fail
docker_opensuse-42_3-amd64

00:00:30

passed #147275
dind allowed to fail
docker_ubuntu-14_04-amd64

00:00:21

passed #147276
dind allowed to fail
docker_ubuntu-16_04-amd64

00:00:21

 
  Build
passed #147283
docker linux amd64
build-centos-6-amd64

00:01:00

passed #147284
docker linux amd64
build-centos-7-amd64

00:01:05

passed #147277
docker linux amd64
build-debian-7-amd64

00:01:02

passed #147288
docker linux amd64
build-debian-7-i386

00:01:09

passed #147278
docker linux amd64
build-debian-8-amd64

00:01:14

passed #147289
docker linux amd64
build-debian-8-i386

00:01:11

passed #147279
docker linux amd64
build-debian-9-amd64

00:01:12

passed #147290
docker linux amd64
build-debian-9-i386

00:01:17

passed #147280
docker linux amd64
build-debian-testing-amd64

00:01:08

passed #147291
docker linux amd64
build-debian-testing-i386

00:01:03

passed #147281
docker linux amd64
build-fedora-25-amd64

00:01:06

passed #147282
docker linux amd64
build-fedora-26-amd64

00:01:04

failed #147292
freebsd amd64
build-freebsd-11-amd64

00:02:49

failed #147293
freebsd i386
build-freebsd-11-i386

00:02:51

passed #147285
docker linux amd64
build-opensuse-42_3-amd64

00:01:05

passed #147286
docker linux amd64
build-ubuntu-14_04-amd64

00:01:02

passed #147287
docker linux amd64
build-ubuntu-16_04-amd64

00:01:01

 
Name Stage Failure
failed
build-freebsd-11-amd64 Build There is an unknown failure, please try again
4 warnings generated.
LD -pthread -L/usr/local/lib -o bird obj/conf/cf-parse.tab.o obj/conf/cf-lex.o obj/conf/conf.o obj/filter/filter.o obj/filter/f-util.o obj/filter/tree.o obj/filter/trie.o obj/lib/bitops.o obj/lib/checksum.o obj/lib/event.o obj/lib/flowspec.o obj/lib/idm.o obj/lib/ip.o obj/lib/lists.o obj/lib/mac.o obj/lib/md5.o obj/lib/mempool.o obj/lib/net.o obj/lib/patmatch.o obj/lib/printf.o obj/lib/resource.o obj/lib/sha1.o obj/lib/sha256.o obj/lib/sha512.o obj/lib/slab.o obj/lib/slists.o obj/lib/tbf.o obj/lib/timer.o obj/lib/xmalloc.o obj/nest/a-path.o obj/nest/a-set.o obj/nest/cli.o obj/nest/cmds.o obj/nest/iface.o obj/nest/locks.o obj/nest/neighbor.o obj/nest/password.o obj/nest/proto.o obj/nest/rt-attr.o obj/nest/rt-dev.o obj/nest/rt-fib.o obj/nest/rt-show.o obj/nest/rt-table.o obj/proto/bfd/bfd.o obj/proto/bfd/io.o obj/proto/bfd/packets.o obj/proto/babel/babel.o obj/proto/babel/packets.o obj/proto/bgp/attrs.o obj/proto/bgp/bgp.o obj/proto/bgp/packets.o obj/proto/ospf/dbdes.o obj/proto/ospf/hello.o obj/proto/ospf/iface.o obj/proto/ospf/lsack.o obj/proto/ospf/lsalib.o obj/proto/ospf/lsreq.o obj/proto/ospf/lsupd.o obj/proto/ospf/neighbor.o obj/proto/ospf/ospf.o obj/proto/ospf/packet.o obj/proto/ospf/rt.o obj/proto/ospf/topology.o obj/proto/pipe/pipe.o obj/proto/radv/packets.o obj/proto/radv/radv.o obj/proto/rip/packets.o obj/proto/rip/rip.o obj/proto/static/static.o obj/sysdep/unix/io.o obj/sysdep/unix/krt.o obj/sysdep/unix/log.o obj/sysdep/unix/main.o obj/sysdep/unix/random.o obj/sysdep/bsd/krt-sock.o
obj/sysdep/bsd/krt-sock.o: In function `krt_read_route':
/usr/home/runner/builds/labs/bird/sysdep/bsd/krt-sock.c:535: undefined reference to `neigh_find2'
cc: error: linker command failed with exit code 1 (use -v to see invocation)
gmake: *** [Makefile:134: bird] Error 1
You can `set autologout = 30' to have tcsh log you off automatically
if you leave the shell idle for more than 30 minutes.
ERROR: Job failed: Process exited with: 1. Reason was: ()
failed
build-freebsd-11-i386 Build There is an unknown failure, please try again
                                             ^
4 warnings generated.
LD -pthread -L/usr/local/lib -o bird obj/conf/cf-parse.tab.o obj/conf/cf-lex.o obj/conf/conf.o obj/filter/filter.o obj/filter/f-util.o obj/filter/tree.o obj/filter/trie.o obj/lib/bitops.o obj/lib/checksum.o obj/lib/event.o obj/lib/flowspec.o obj/lib/idm.o obj/lib/ip.o obj/lib/lists.o obj/lib/mac.o obj/lib/md5.o obj/lib/mempool.o obj/lib/net.o obj/lib/patmatch.o obj/lib/printf.o obj/lib/resource.o obj/lib/sha1.o obj/lib/sha256.o obj/lib/sha512.o obj/lib/slab.o obj/lib/slists.o obj/lib/tbf.o obj/lib/timer.o obj/lib/xmalloc.o obj/nest/a-path.o obj/nest/a-set.o obj/nest/cli.o obj/nest/cmds.o obj/nest/iface.o obj/nest/locks.o obj/nest/neighbor.o obj/nest/password.o obj/nest/proto.o obj/nest/rt-attr.o obj/nest/rt-dev.o obj/nest/rt-fib.o obj/nest/rt-show.o obj/nest/rt-table.o obj/proto/bfd/bfd.o obj/proto/bfd/io.o obj/proto/bfd/packets.o obj/proto/babel/babel.o obj/proto/babel/packets.o obj/proto/bgp/attrs.o obj/proto/bgp/bgp.o obj/proto/bgp/packets.o obj/proto/ospf/dbdes.o obj/proto/ospf/hello.o obj/proto/ospf/iface.o obj/proto/ospf/lsack.o obj/proto/ospf/lsalib.o obj/proto/ospf/lsreq.o obj/proto/ospf/lsupd.o obj/proto/ospf/neighbor.o obj/proto/ospf/ospf.o obj/proto/ospf/packet.o obj/proto/ospf/rt.o obj/proto/ospf/topology.o obj/proto/pipe/pipe.o obj/proto/radv/packets.o obj/proto/radv/radv.o obj/proto/rip/packets.o obj/proto/rip/rip.o obj/proto/static/static.o obj/sysdep/unix/io.o obj/sysdep/unix/krt.o obj/sysdep/unix/log.o obj/sysdep/unix/main.o obj/sysdep/unix/random.o obj/sysdep/bsd/krt-sock.o
obj/sysdep/bsd/krt-sock.o: In function `krt_read_route':
/usr/home/runner/builds/labs/bird/sysdep/bsd/krt-sock.c:535: undefined reference to `neigh_find2'
cc: error: linker command failed with exit code 1 (use -v to see invocation)
gmake: *** [Makefile:134: bird] Error 1
You can press Ctrl-L while in the shell to clear the screen.
ERROR: Job failed: Process exited with: 1. Reason was: ()