1. 01 Aug, 2018 2 commits
  2. 28 Jul, 2018 2 commits
  3. 17 Jul, 2018 3 commits
  4. 06 Jul, 2018 1 commit
    • Ondřej Zajíček's avatar
      Nest: Fix race condition during reconfiguration, part 2 · 470efcb9
      Ondřej Zajíček authored
      If export filter is changed during reconfiguration and a route disappears
      between reconfiguration and refeed (e.g., if the route is a static route
      also removed during the reconfiguration), the route is not withdrawn.
      
      The issue was fixed for regular channels by an earlier patch. This patch
      fixes the issue for channels in RA_ACCEPTED mode (first-pass-the-filter),
      used by BGP with 'secondary' option.
      470efcb9
  5. 03 Jul, 2018 1 commit
    • Ondřej Zajíček's avatar
      Nest: Fix race condition during reconfiguration · cbfdf6ed
      Ondřej Zajíček authored
      If export filter is changed during reconfiguration and a route disappears
      between reconfiguration and refeed (e.g., if the route is a static route
      also removed during the reconfiguration), the route is not withdrawn.
      The patch fixes that by adding tx reconfiguration timestamp.
      cbfdf6ed
  6. 24 Apr, 2018 3 commits
  7. 23 Apr, 2018 1 commit
  8. 24 Mar, 2018 2 commits
  9. 23 Mar, 2018 1 commit
  10. 22 Mar, 2018 1 commit
  11. 21 Mar, 2018 2 commits
  12. 19 Mar, 2018 1 commit
  13. 14 Mar, 2018 1 commit
    • Jan Maria Matejka's avatar
      Filter: make bgpmask literals real constructors · e8bc64e3
      Jan Maria Matejka authored
      The bgpmask literals can include expressions. This is OK but they have
      to be interpreted as soon as the code is run, not in the time the code
      is used as value.
      
      This led to strange behavior like rewriting bgpmasks when they shan't
      be rewritten:
      
      	function mask_generator(int as)
      	{
      		return [= * as * =];
      	}
      
      	function another()
      	bgpmask m1;
      	bgpmask m2;
      	{
      		m1 = mask_generator(10);
      		m2 = mask_generator(20);
      		if (m1 == m2) {
      			print("strange"); # this would happen
      		}
      	}
      
      Moreover, sending this to CLI would cause stack overflow and knock down the
      whole BIRD, as soon as there is at least one route to execute the given
      filter on.
      
      	show route filter bgpmask mmm; bgppath ppp; { ppp = +empty+; mmm = [= (ppp ~ mmm) =]; print(mmm); accept; }
      
      The magic match operator (~) inside the bgpmask literal would try to
      resolve mmm, which points to the same bgpmask so it would resolve
      itself, call the magic match operator and vice versa.
      
      After this patch, the bgpmask literal will get resolved as soon as it's
      assigned to mmm and it also will return a type error as bool is not
      convertible to ASN in BIRD.
      e8bc64e3
  14. 13 Mar, 2018 3 commits
    • Jan Maria Matejka's avatar
      Filters: Removed FI_COMMA, not used for 19 years. · 74bfd2f9
      Jan Maria Matejka authored
      This instruction was removed in the commit linked below
      and never used ever again. Rest in peace.
      
      commit 84c7e194
      Author: Pavel Machek <pavel@ucw.cz>
      Date:   Tue Mar 2 19:49:28 1999 +0000
      74bfd2f9
    • Jan Maria Matejka's avatar
      Filter: recursion to loop · 7c601e6b
      Jan Maria Matejka authored
      It was supposed to do tail-recursion in interpret() but it didn't
      compile as such. Converting it to loop makes a significant filter
      performance improvement for flat filters.
      7c601e6b
    • Maria Jan Matejka's avatar
      Filter: Instruction codes named as enum · 5a14df39
      Maria Jan Matejka authored
      The two-letter instructions were quite messy but they could be easily
      read from memory dumps. Now GDB (since 2012) supports pretty printing
      enum values and GCC checks the switch construction for missing enum
      values so we are converting the nice two-byte values to enums.
      
      Anyway, the enum still keeps the old two-byte values to be able to read
      the instruction codes even without GDB from plain memory dump.
      5a14df39
  15. 07 Mar, 2018 1 commit
  16. 23 Jan, 2018 1 commit
    • Ondřej Zajíček's avatar
      IO: Fix socket priority · d6cf9961
      Ondřej Zajíček authored
      On Linux, setting the ToS will also set the priority and the range of
      accepted values is quite limited (masked by 0x1e). Therefore, 0xc0 is
      translated to a priority of 0, not something we want, overriding the
      "7" priority which was set previously explicitely. To avoid that, just
      move setting priority later in the code.
      
      Thanks to Vincent Bernat for the patch.
      d6cf9961
  17. 16 Jan, 2018 2 commits
  18. 03 Jan, 2018 1 commit
  19. 02 Jan, 2018 1 commit
    • Ondřej Zajíček's avatar
      Remove libhistory check · cce6ba4d
      Ondřej Zajíček authored
      According to GNU Readline developers, if we link with libreadline then
      there is no need to link with libhistory at all.
      cce6ba4d
  20. 14 Dec, 2017 1 commit
  21. 28 Nov, 2017 1 commit
    • Ondřej Zajíček's avatar
      Babel: Parse flags in Hello TLV · 1e8721e2
      Ondřej Zajíček authored
      RFC6126bis introduces a flags field for the Hello TLV, and adds a unicast flag
      that is used to signify that a hello was sent as unicast. This adds parsing of
      the flags field and ignores such unicast hellos, which preserves compatibility
      until we can add a proper implementation of the unicast hello mechanism.
      
      Thanks to Toke Hoiland-Jorgensen for the patch.
      1e8721e2
  22. 09 Nov, 2017 1 commit
  23. 10 Oct, 2017 3 commits
  24. 06 Oct, 2017 1 commit
  25. 04 Oct, 2017 1 commit
    • Michal 'vorner' Vaner's avatar
      RAdv: Support for more specific routes (RFC 4191) · 2a95e633
      Michal 'vorner' Vaner authored
      The patch implements Default Router Preferences and More-Specific Routes
      (RFC 4191) for RAdv protocol, allowing to announce router preference and
      more specific routes in router advertisements. Routes can be exported to
      RAdv like to regular routing protocols.
      
      Some cleanups, bugfixes and other changes done by Ondrej Zajicek.
      2a95e633
  26. 20 Sep, 2017 1 commit
  27. 19 Sep, 2017 1 commit
    • Ondřej Zajíček's avatar
      BGP: Shutdown communication (RFC 8203) · cd1d9961
      Ondřej Zajíček authored
      The patch implements BGP Administrative Shutdown Communication (RFC 8203)
      allowing BGP operators to pass messages related to BGP session
      administrative shutdown/restart. It handles both transmit and receive of
      shutdown messages. Messages are logged and may be displayed by show
      protocol all command.
      
      Thanks to Job Snijders for the basic patch.
      cd1d9961