1. 02 Apr, 2019 1 commit
  2. 16 Dec, 2018 1 commit
  3. 12 Dec, 2018 1 commit
    • Ondřej Zajíček's avatar
      BGP: Do not prepend ASN in export from non-RS EBGP to RS EBGP · 532116e7
      Ondřej Zajíček authored
      When route is exported to regular EBGP, local ASN should be prepended to
      AS_PATH. When route is propagated by route server (between RS-marked
      EBGP peers), it should not change AS_PATH. Question is what to do in
      other cases (from non-RS EBGP, IBGP, or locally originated to RS EBGP).
      
      In 1.6.x, we did not prepend ASN in non-RS EBGP or IBGP to RS EBGP, but
      we prepended in local to RS EBGP.
      
      In 2.0.x, we changed that so only RS-EBGP to RS-EBGP is not prepended.
      We received some negative responses (thanks to heisenbug and Alexander
      Zubkov), we decided to change it back. One reason is that it is simple
      to modify the AS_PATH by filters, but not possible to un-modify
      changes done by BGP itself. Also, as 1.6.x behavior was not really
      consistent, the final behavior is that ASN is never prepended when
      exported to RS EBGP, like to IBGP.
      
      Note that i do not express an opinion about whether such configurations
      are even reasonable.
      532116e7
  4. 04 Dec, 2018 1 commit
    • Jan Maria Matejka's avatar
      Terminology cleanup: The import_control hook is now called preexport. · 14375237
      Jan Maria Matejka authored
      Once upon a time, far far away, there were the old Bird developers
      discussing what direction of route flow shall be called import and
      export. They decided to say "import to protocol" and "export to table"
      when speaking about a protocol. When speaking about a table, they
      spoke about "importing to table" and "exporting to protocol".
      
      The latter terminology was adopted in configuration, then also the
      bird CLI in commit ea2ae6dd started to use it (in year 2009). Now
      it's 2018 and the terminology is the latter. Import is from protocol to
      table, export is from table to protocol. Anyway, there was still an
      import_control hook which executed right before route export.
      
      One thing is funny. There are two commits in April 1999 with just two
      minutes between them. The older announces the final settlement
      on config terminology, the newer uses the other definition. Let's see
      their commit messages as the git-log tool shows them (the newer first):
      
          commit 9e0e485e
          Author: Martin Mares <mj@ucw.cz>
          Date:   Mon Apr 5 20:17:59 1999 +0000
      
      	Added some new protocol hooks (look at the comments for better explanation):
      
      		make_tmp_attrs          Convert inline attributes to ea_list
      		store_tmp_attrs         Convert ea_list to inline attributes
      		import_control          Pre-import decisions
      
          commit 5056c559
          Author: Martin Mares <mj@ucw.cz>
          Date:   Mon Apr 5 20:15:31 1999 +0000
      
      	Changed syntax of attaching filters to protocols to hopefully the final
      	version:
      
      		EXPORT <filter-spec>    for outbound routes (i.e., those announced
      					by BIRD to the rest of the world).
      		IMPORT <filter-spec>    for inbound routes (i.e., those imported
      					by BIRD from the rest of the world).
      
      	where <filter-spec> is one of:
      
      		ALL                     pass all routes
      		NONE                    drop all routes
      		FILTER <name>           use named filter
      		FILTER { <filter> }     use explicitly defined filter
      
      	For all protocols, the default is IMPORT ALL, EXPORT NONE. This includes
      	the kernel protocol, so that you need to add EXPORT ALL to get the previous
      	configuration of kernel syncer (as usually, see doc/bird.conf.example for
      	a bird.conf example :)).
      
      Let's say RIP to this almost 19-years-old inconsistency. For now, if you
      import a route, it is always from protocol to table. If you export a
      route, it is always from table to protocol.
      
      And they lived happily ever after.
      14375237
  5. 20 Nov, 2018 1 commit
    • Ondřej Zajíček's avatar
      The MRT protocol · 863ecfc7
      Ondřej Zajíček authored
      The new MRT protocol is responsible for periodic RIB table dumps in the
      MRT format (RFC 6396). Also the existing code for BGP4MP MRT dumps is
      refactored and splitted between BGP to MRT protocols, will be more
      integrated into MRT in the future.
      
      Example:
      
      protocol mrt {
              table "*";
              filename "%N_%F_%T.mrt";
              period 60;
      }
      
      It is partially based on the old MRT code from Pavel Tvrdik.
      863ecfc7
  6. 31 Jul, 2018 1 commit
  7. 29 Jun, 2018 1 commit
  8. 13 Jun, 2018 1 commit
  9. 30 May, 2018 1 commit
    • Jan Maria Matejka's avatar
      Nest: Removing separate tmpa from route propagation · 13c0be19
      Jan Maria Matejka authored
      This is a fundamental change of an original (1999) concept of route
      processing inside BIRD. During import/export, there was a temporary
      ea_list created which was to be used instead of the another one inside
      the route itself.
      
      This led to some confusion, quirks, and strange filter code that handled
      extended route attributes. Dropping it now.
      
      The protocol interface has changed in an uniform way -- the
      `struct ea_list *attrs` argument has been removed from store_tmp_attrs(),
      import_control(), rt_notify() and get_route_info().
      13c0be19
  10. 29 May, 2018 1 commit
  11. 12 Apr, 2018 1 commit
  12. 02 Jan, 2018 1 commit
  13. 13 Dec, 2017 1 commit
  14. 10 Dec, 2017 1 commit
  15. 12 Sep, 2017 1 commit
  16. 22 Mar, 2017 1 commit
    • Ondřej Zajíček's avatar
      BGP: Support for MPLS labels and VPN SAFI · 1e37e35c
      Ondřej Zajíček authored
      Basic support for SAFI 4 and 128 (MPLS labeled IP and VPN) for IPv4 and
      IPv6. Should work for route reflector, but does not properly handle
      originating routes with next hop self.
      
      Based on patches from Jan Matejka.
      1e37e35c
  17. 23 Feb, 2017 1 commit
  18. 20 Feb, 2017 1 commit
  19. 19 Feb, 2017 1 commit
  20. 07 Feb, 2017 1 commit
  21. 24 Jan, 2017 1 commit
  22. 22 Jan, 2017 1 commit
  23. 22 Dec, 2016 1 commit
    • Jan Moskyto Matejka's avatar
      Merged multipath and single-path data structures. · 4e276a89
      Jan Moskyto Matejka authored
      Dropped struct mpnh and mpnh_*()
      Now struct nexthop exists, nexthop_*(), and also included struct nexthop
      into struct rta.
      
      Also converted RTD_DEVICE and RTD_ROUTER to RTD_UNICAST. If it is needed
      to distinguish between these two cases, RTD_DEVICE is equivalent to
      IPA_ZERO(a->nh.gw), RTD_ROUTER is then IPA_NONZERO(a->nh.gw).
      
      From now on, we also explicitely want C99 compatible compiler. We assume
      that this 20-year norm should be known almost everywhere.
      4e276a89
  24. 07 Dec, 2016 2 commits
  25. 25 Nov, 2016 1 commit
    • Ondřej Zajíček's avatar
      BGP: Fix memory leak in graceful restart code · ed1a908e
      Ondřej Zajíček authored
      Prefix and bucket tables are initialized when entering established state
      but not explicitly freed when leaving it (that is handled by protocol
      restart). With graceful restart, BGP may enter and leave established
      state multiple times without hard protocol restart causing memory leak.
      ed1a908e
  26. 15 Nov, 2016 1 commit
  27. 01 Nov, 2016 1 commit
  28. 03 Oct, 2016 1 commit
    • Ondřej Zajíček's avatar
      BGP: Support for large communities · 66dbdbd9
      Ondřej Zajíček authored
      Add support for large communities (draft-ietf-idr-large-community),
      96bit alternative to RFC 1997 communities.
      
      Thanks to Matt Griswold for the original patch.
      66dbdbd9
  29. 29 Jun, 2016 1 commit
  30. 08 Jun, 2015 2 commits
  31. 21 Feb, 2015 1 commit
  32. 24 Oct, 2014 1 commit
  33. 01 Dec, 2013 1 commit
  34. 21 Oct, 2013 1 commit
  35. 16 Apr, 2013 1 commit
  36. 12 Nov, 2012 1 commit
  37. 10 Nov, 2012 1 commit
    • Ondřej Zajíček's avatar
      Allows rejected routes to be kept and examined. · cf98be7b
      Ondřej Zajíček authored
      When 'import keep rejected' protocol option is activated, routes
      rejected by the import filter are kept in the routing table, but they
      are hidden and not propagated to other protocols. It is possible to
      examine them using 'show route rejected'.
      cf98be7b
  38. 14 Aug, 2012 1 commit
    • Ondřej Zajíček's avatar
      Implements ADD-PATH extension for BGP. · 094d2bdb
      Ondřej Zajíček authored
      Allows to send and receive multiple routes for one network by one BGP
      session. Also contains necessary core changes to support this (routing
      tables accepting several routes for one network from one protocol).
      It needs some more cleanup before merging to the master branch.
      094d2bdb