1. 25 Dec, 2008 1 commit
    • Ondřej Zajíček's avatar
      fixes some 64-bit related bugs. · 083c43e2
      Ondřej Zajíček authored
      Filter code used 'aux' integer field of 'symbol' struct to store ptr
      to next symbol and both 'aux2' and 'def' fields for value.
      Changed to just 'def' for value and 'aux2' for ptr to next symbol.
      Also another minor bugfix.
      083c43e2
  2. 24 Dec, 2008 2 commits
    • Ondřej Zajíček's avatar
      Adds support for fallback to capabilityless BGP connect · 165a6227
      Ondřej Zajíček authored
      When capability related error is received, next connect will be
      without capabilities. Also cease error subcodes descriptions
      (according to [RFC4486]) are added.
      165a6227
    • Ondřej Zajíček's avatar
      Fixes bug related to reconfiguration of BGP. · 59121155
      Ondřej Zajíček authored
      BGP keeps its copy of configuration ptr and didn't update it during
      reconfiguration. But old configuration is freed during reconfiguration.
      That leads to unnecessary reset of BGP connection during reconfiguration
      (old conf is corrupted and therefore different) and possibly other strange
      behavior.
      59121155
  3. 19 Dec, 2008 1 commit
    • Ondřej Zajíček's avatar
      Major changes to BGP · 11b32d91
      Ondřej Zajíček authored
      Fixes two race conditions causing crash of Bird, several unhandled
      cases during BGP initialization, and some other bugs. Also changes
      handling of startup delay to be more useful and implement
      reporting of last error in 'show protocols' command.
      11b32d91
  4. 18 Dec, 2008 1 commit
    • Ondřej Zajíček's avatar
      Fixes nasty bug in event processing. · b933281e
      Ondřej Zajíček authored
      WALK_LIST_DELSAFE (in ev_run_list) is not safe with regard
      to deletion of next node. When some events are rescheduled
      during event execution, it may lead to deletion of next
      node and some events are skipped. Such skipped nodes remain
      in temporary list on stack and the last of them contains
      'next' pointer to stack area. When this event is later
      scheduled, it damages stack area trying to remove it from
      the list, which leads to random crashes with funny
      backtraces :-) .
      b933281e
  5. 12 Dec, 2008 1 commit
  6. 08 Dec, 2008 1 commit
    • Ondřej Zajíček's avatar
      Fixes core state machine. · d6a836f8
      Ondřej Zajíček authored
      The core state machine was broken - it didn't free resources
      in START -> DOWN transition and might freed resources after
      UP -> STOP transition before protocol turned down. It leads
      to deadlock on olock acquisition when lock was not freed
      during previous stop.
      
      The current behavior is that resources, allocated during
      DOWN -> * transition, are freed in * -> DOWN transition,
      and flushing (scheduled in UP -> *) just counteract
      feeding (scheduled in * -> UP). Protocol fell down
      when both flushing is done (if needed) and protocol
      reports DOWN.
      
      BTW, is thera a reason why neighbour cache item acquired
      by protocol is not tracked by resource mechanism?
      d6a836f8
  7. 22 Nov, 2008 1 commit
    • Ondřej Zajíček's avatar
      Fixes race condition leading to memory corruption and crash. · fbde6c39
      Ondřej Zajíček authored
      When protocol started, feeding was scheduled. If protocol
      got down before feeding was executed, then function
      responsible for connecting protocol to kernel routing
      tables was called after the function responsible for
      disconnecting, then resource pool of protocol was freed,
      but freed linked list structures remains in the list.
      fbde6c39
  8. 21 Nov, 2008 4 commits
  9. 16 Nov, 2008 2 commits
  10. 14 Nov, 2008 3 commits
  11. 08 Nov, 2008 2 commits
  12. 06 Nov, 2008 1 commit
  13. 05 Nov, 2008 2 commits
  14. 04 Nov, 2008 2 commits
  15. 01 Nov, 2008 2 commits
  16. 29 Oct, 2008 1 commit
    • Ondřej Zajíček's avatar
      Fix race condition that breaks BGP connections after reconfigure. · e16466b3
      Ondřej Zajíček authored
      RFC says that only connections in OpenConfirm and Established state
      should participate in connection collision detection.
      
      The current implementation leads to race condition when both sides
      are trying to connect at the almost same time, then both sides
      receive OPEN message by different connections at the almost same
      time and close the other connection. Both connections are
      closed and the both sides end in  start/idle or start/active
      state.
      e16466b3
  17. 28 Oct, 2008 1 commit
  18. 27 Oct, 2008 2 commits
    • Ondřej Zajíček's avatar
      Merge branch 'dev' into out · a98fbf0f
      Ondřej Zajíček authored
      a98fbf0f
    • Ondřej Zajíček's avatar
      Two new informative CLI commands for OSPF. · a3b70dc4
      Ondřej Zajíček authored
      Two new CLI commands for OSPF giving nice informative (and still machine
      parsable) representation of OSPF network graph (based on datas from the
      LSA database).
      
      The first command (show ospf topology) shows routers, networks and stub
      networks, The second command (show ospf state) shows also external
      routes and area-external networks and routers propagated by given area
      boundary router.
      a3b70dc4
  19. 26 Oct, 2008 10 commits