lib/nsrep: refactor a piece of code

This is yet another logically equivalent change after 270d9964.
Now it's written in a way that expresses the original intention more
clearly and without copy&paste or long lines.

It seems easiest to verify by inspecting the meaning of the code
*separartely* for the two cases, based on condition:
cur_addr_score < KR_NS_TIMEOUT
27 jobs for nsrep-hotfix in 26 minutes and 29 seconds (queued for 9 seconds)
Status Job ID Name Coverage
  Build
passed #269256
amd64 linux docker
archive

00:00:56

passed #269257
amd64 linux docker
build

00:01:04

passed #269258
amd64 linux docker
build-asan

00:01:04

passed #269259
docker
kres-gen

00:01:00

 
  Test
passed #269260
docker delayed
build:darwin

00:00:23

passed #269261
amd64 linux docker
deckard

00:02:34

passed #269262
docker delayed
doc

00:01:13

passed #269263
dind
docker

00:02:11

passed #269264
docker delayed
lint:other

00:00:55

passed #269265
amd64 linux docker delayed
lint:pedantic

00:01:07

passed #269266
amd64 linux docker
lint:scan-build

00:02:23

passed #269267
amd64 linux docker
lint:tidy

00:03:06

passed #269268
privileged
pkg:epel-7

00:01:59

passed #269269
privileged
pkg:fedora-29

00:03:13

passed #269270
amd64 linux docker
respdiff:basic

00:05:00

passed #269271
amd64 linux docker delayed
test:valgrind

00:02:18

 
  Extended
failed #269273
respdiff
fwd-tls6-kresd.udp6

00:20:23

passed #269274
respdiff
fwd-udp6-kresd.udp6

00:12:23

failed #269278
respdiff
fwd-udp6-unbound.tcp6

00:10:19

passed #269279
respdiff
fwd-udp6-unbound.tls6

00:17:53

passed #269277
respdiff
fwd-udp6-unbound.udp6

00:08:22

passed #269276
respdiff
iter.tls6

00:06:52

passed #269275
respdiff
iter.udp6

00:11:23

passed #269272
amd64 linux docker
pytests

00:04:49

passed #269280
respdiff
resperf:fwd-tls6.udp-asan

00:15:48

passed #269281
respdiff
resperf:fwd-udp6.udp-asan

00:15:48

passed #269282
respdiff
resperf:iter.udp-asan

00:10:48

 
Name Stage Failure
failed
fwd-tls6-kresd.udp6 Extended
Running after script...
$ cp -t . respdiff_commitdir/$RESPDIFF_TEST/j* ||:
$ cp -t . respdiff_commitdir/*$RESPDIFF_TEST*.png ||:
Uploading artifacts...
Runtime platform arch=amd64 os=linux pid=78551 revision=5a147c92 version=11.11.1
./j*: found 11 matching files

./*.png: found 3 matching files

Uploading artifacts to coordinator... ok
id=269273 responseStatus=201 Created token=Akn-EMP-
ERROR: Job failed: exit status 1
failed
fwd-udp6-unbound.tcp6 Extended
Running after script...
$ cp -t . respdiff_commitdir/$RESPDIFF_TEST/j* ||:
$ cp -t . respdiff_commitdir/*$RESPDIFF_TEST*.png ||:
Uploading artifacts...
Runtime platform arch=amd64 os=linux pid=76563 revision=5a147c92 version=11.11.1
./j*: found 11 matching files

./*.png: found 3 matching files

Uploading artifacts to coordinator... ok
id=269278 responseStatus=201 Created token=ye7GSNyX
ERROR: Job failed: exit status 1