resolve: use more sensitive detection of KR_STATE_FAIL

I don't know any particular case where the bit-test would succeed and
equality wouldn't, but it seems better to take no chances.
25 jobs for bogus-clean in 41 minutes and 59 seconds (queued for 8 seconds)
latest
Status Job ID Name Coverage
  Build
passed #177949
docker linux amd64
build:clang:linux:amd64

00:00:43

passed #177948
docker linux amd64
build:linux:amd64

00:00:47

passed #177950
docker linux amd64 allowed to fail
srpm

00:00:27

 
  Test
passed #177957
docker linux amd64
deckard:linux:amd64

00:01:20

passed #177962
privileged
distro:epel-7

00:01:43

passed #177961
privileged
distro:fedora-29

00:02:14

passed #177956
docker
doc

00:00:52

passed #177955
docker linux amd64
installcheck:linux:amd64

00:01:00

passed #177958
docker linux amd64
installcheck:valgrind:linux:amd64

00:01:48

passed #177952
docker
lint:c

00:02:25

failed #177953
docker allowed to fail
lint:clang-scan-build

00:01:09

passed #177951
docker
lint:lua

00:00:35

passed #177960
docker linux amd64
respdiff:iter:udp:linux:amd64

00:02:25

passed #177954
docker linux amd64
test:linux:amd64

00:01:04

passed #177959
docker linux amd64
test:linux:amd64:valgrind

00:01:14

 
  Respdiff
failed #177963
respdiff
respdiff:fwd-tls6-kresd.udp6

00:22:12

failed #177964
respdiff
respdiff:fwd-udp6-kresd.udp6

00:28:42

failed #177968
respdiff
respdiff:fwd-udp6-unbound.tcp6

00:38:45

failed #177969
respdiff
respdiff:fwd-udp6-unbound.tls6

00:38:45

failed #177967
respdiff
respdiff:fwd-udp6-unbound.udp6

00:26:11

failed #177966
respdiff
respdiff:iter.tls6

00:27:42

failed #177965
respdiff
respdiff:iter.udp6

00:35:12

failed #177970
respdiff
resperf:fwd-tls6.udp-asan

00:23:03

failed #177971
respdiff
resperf:fwd-udp6.udp-asan

00:13:24

failed #177972
respdiff
resperf:iter.udp-asan

00:36:04

 
Name Stage Failure
failed
respdiff:iter.tls6 Respdiff
~/builds/ea0ef08e/3/knot/knot-resolver
Running after script...
$ cp -t . respdiff_commitdir/$RESPDIFF_TEST/j* ||:
$ cp -t . respdiff_commitdir/*$RESPDIFF_TEST*.png ||:
Uploading artifacts...
./j*: found 9 matching files
./*.png: found 3 matching files
Uploading artifacts to coordinator... ok id=177966 responseStatus=201 Created token=6YSYfKJH
ERROR: Job failed: exit status 1
failed
resperf:fwd-tls6.udp-asan Respdiff
kresd_fwd_target_1  |   Right alloca redzone:    cb
kresd_fwd_target_1 | ==8==ABORTING
$ exit $EXITCODE
Running after script...
$ cp -t . resperf_commitdir/$RESPERF_TEST/j* ||:
Uploading artifacts...
./j*: found 7 matching files
Uploading artifacts to coordinator... ok id=177970 responseStatus=201 Created token=u96Hy7Xm
ERROR: Job failed: exit status 1
failed
respdiff:iter.udp6 Respdiff
~/builds/ea0ef08e/2/knot/knot-resolver
Running after script...
$ cp -t . respdiff_commitdir/$RESPDIFF_TEST/j* ||:
$ cp -t . respdiff_commitdir/*$RESPDIFF_TEST*.png ||:
Uploading artifacts...
./j*: found 9 matching files
./*.png: found 3 matching files
Uploading artifacts to coordinator... ok id=177965 responseStatus=201 Created token=skNeYYTr
ERROR: Job failed: exit status 1
failed
resperf:iter.udp-asan Respdiff
kresd_1    |   Right alloca redzone:    cb
kresd_1 | ==7==ABORTING
$ exit $EXITCODE
Running after script...
$ cp -t . resperf_commitdir/$RESPERF_TEST/j* ||:
Uploading artifacts...
./j*: found 7 matching files
Uploading artifacts to coordinator... ok id=177972 responseStatus=201 Created token=NjjhkyRC
ERROR: Job failed: exit status 1
failed
respdiff:fwd-udp6-unbound.tcp6 Respdiff
~/builds/ea0ef08e/5/knot/knot-resolver
Running after script...
$ cp -t . respdiff_commitdir/$RESPDIFF_TEST/j* ||:
$ cp -t . respdiff_commitdir/*$RESPDIFF_TEST*.png ||:
Uploading artifacts...
./j*: found 9 matching files
./*.png: found 3 matching files
Uploading artifacts to coordinator... ok id=177968 responseStatus=201 Created token=16stgMmb
ERROR: Job failed: exit status 1
failed
respdiff:fwd-udp6-unbound.tls6 Respdiff
~/builds/ea0ef08e/6/knot/knot-resolver
Running after script...
$ cp -t . respdiff_commitdir/$RESPDIFF_TEST/j* ||:
$ cp -t . respdiff_commitdir/*$RESPDIFF_TEST*.png ||:
Uploading artifacts...
./j*: found 9 matching files
./*.png: found 3 matching files
Uploading artifacts to coordinator... ok id=177969 responseStatus=201 Created token=rg_r2p7a
ERROR: Job failed: exit status 1
failed
respdiff:fwd-udp6-unbound.udp6 Respdiff
~/builds/ea0ef08e/4/knot/knot-resolver
Running after script...
$ cp -t . respdiff_commitdir/$RESPDIFF_TEST/j* ||:
$ cp -t . respdiff_commitdir/*$RESPDIFF_TEST*.png ||:
Uploading artifacts...
./j*: found 9 matching files
./*.png: found 3 matching files
Uploading artifacts to coordinator... ok id=177967 responseStatus=201 Created token=YjpJW1xi
ERROR: Job failed: exit status 1
failed
respdiff:fwd-udp6-kresd.udp6 Respdiff
~/builds/ea0ef08e/1/knot/knot-resolver
Running after script...
$ cp -t . respdiff_commitdir/$RESPDIFF_TEST/j* ||:
$ cp -t . respdiff_commitdir/*$RESPDIFF_TEST*.png ||:
Uploading artifacts...
./j*: found 9 matching files
./*.png: found 3 matching files
Uploading artifacts to coordinator... ok id=177964 responseStatus=201 Created token=UoumH7zJ
ERROR: Job failed: exit status 1
failed
resperf:fwd-udp6.udp-asan Respdiff
kresd_fwd_target_1  |   Right alloca redzone:    cb
kresd_fwd_target_1 | ==8==ABORTING
$ exit $EXITCODE
Running after script...
$ cp -t . resperf_commitdir/$RESPERF_TEST/j* ||:
Uploading artifacts...
./j*: found 7 matching files
Uploading artifacts to coordinator... ok id=177971 responseStatus=201 Created token=6b_UurcX
ERROR: Job failed: exit status 1
failed
respdiff:fwd-tls6-kresd.udp6 Respdiff
~/builds/ea0ef08e/0/knot/knot-resolver
Running after script...
$ cp -t . respdiff_commitdir/$RESPDIFF_TEST/j* ||:
$ cp -t . respdiff_commitdir/*$RESPDIFF_TEST*.png ||:
Uploading artifacts...
./j*: found 9 matching files
./*.png: found 3 matching files
Uploading artifacts to coordinator... ok id=177963 responseStatus=201 Created token=exD3CDJ2
ERROR: Job failed: exit status 1
failed
lint:clang-scan-build Test
  CCLD	modules/bogus_log/bogus_log.so
CCLD modules/hints/hints.so
CCLD modules/stats/stats.so
scan-build: 33 bugs found.
scan-build: Run 'scan-view /builds/knot/knot-resolver/scan-results/2018-09-25-124449-14-1' to examine bug reports.
Uploading artifacts...
scan-results: found 38 matching files
Uploading artifacts to coordinator... ok id=177953 responseStatus=201 Created token=SuUxb-G_
ERROR: Job failed: exit code 1