Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
Knot Resolver
Knot Resolver
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 124
    • Issues 124
    • List
    • Boards
    • Labels
    • Milestones
  • Merge Requests 17
    • Merge Requests 17
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Knot projects
  • Knot ResolverKnot Resolver
  • Merge Requests
  • !815

Merged
Opened May 02, 2019 by Vladimír Čunát@vcunat
  • Report abuse
Report abuse

lib/nsrep: refactor a piece of code

lib/nsrep: fix a bug in choosing when many timed out

Commit 270d9964 was wrong (released in >= 2.4.0). I had reviewed that change carefully, but still I didn't notice the problem with continue just above the changed hunk.

This is yet another logically equivalent change after 270d9964. Now it's written in a way that expresses the original intention more clearly and without copy&paste or long lines.

It seems easiest to verify by inspecting the meaning of the code separartely for the two cases, based on condition: cur_addr_score < KR_NS_TIMEOUT

Edited May 30, 2019 by Vladimír Čunát
  • Discussion 5
  • Commits 1
  • Pipelines 2
  • Changes 1
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
1
Labels
bug
Assign labels
  • View project labels
Reference: knot/knot-resolver!815

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.