Skip to content
Snippets Groups Projects

worker: fixed infinite loop on send failure

Merged Marek Vavrusa requested to merge marek/fix-infinite-loop-on-send-error into master

The problem here is when qr_task_send() returns an error, the following error handler will attempt to cancel all tasks that were started on the same connection, but that will only work for the first task (which is finished), the qr_task_on_send() will have no effect on tasks in progress as the passed handle is NULL, and the task->finished is false, thus looping infinitely.

The solution here is to let the rest of the tasks complete, even though sending answer back will fail (which is fine).

Merge request reports

Pipeline #35427 passed with warnings

Pipeline passed with warnings for 90f72d63 on marek/fix-infinite-loop-on-send-error

Test coverage 71.70% (6.00%) from 1 job

Merged by Petr ŠpačekPetr Špaček 6 years ago (Apr 18, 2018 11:10am UTC)

Loading

Pipeline #35529 passed with warnings

Pipeline passed with warnings for 26c3d7a6 on master

Test coverage 71.70% (6.00%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading