Inconsistent quoting in log files
I've been looking at the Knot log files, with the view to parse them with scripts. One of the things that stands out is inconsistent quoting. For example, when knot starts up, it logs the interfaces to which it binds, and these are quoted, as are the UID and GID:
2017-07-30T09:29:12 info: Knot DNS 2.3.3 starting 2017-07-30T09:29:12 info: binding to interface '::1@53' 2017-07-30T09:29:12 info: binding to interface '127.0.0.1@53' 2017-07-30T09:29:12 info: changing GID to '10073' 2017-07-30T09:29:12 info: changing UID to '10073'
When an inactive TCP client connection is closed, this is also logged with quotes:
2017-07-30T09:28:44 notice: TCP, terminated inactive client, address '126.96.36.199@16639'
However, in other places (such as XFR), addresses are NOT quoted:
2017-07-30T05:15:36 info: [.] NOTIFY, incoming, 188.8.131.52@60588: received serial 2017073000 2017-07-30T05:15:36 info: [.] refresh, outgoing, 184.108.40.206@53: master has newer serial 2017072901 -> 2017073000 2017-07-30T05:15:37 info: [.] IXFR, incoming, 220.127.116.11@53: starting 2017-07-30T05:15:37 info: [.] IXFR, incoming, 18.104.22.168@53: finished, serial 2017072901 -> 2017073000, 0.79 seconds, 85 messages, 1714104 bytes
It would be a good improvement if this was all made consistent, and ideally, you should drop the quotes. They are entirely unnecessary.