Commit 444472d7 authored by Libor Peltan's avatar Libor Peltan

xfr/notify: not logging malformed and acl-blocked queries

the acl blocks are still loged in debug level anyway
parent 98325ab6
......@@ -175,8 +175,11 @@ int axfr_process_query(knot_pkt_t *pkt, knotd_qdata_t *qdata)
int ret = axfr_query_init(qdata);
axfr = qdata->extra->ext;
if (ret != KNOT_EOK) {
AXFROUT_LOG(LOG_ERR, qdata, "failed to start (%s)",
knot_strerror(ret));
if (qdata->rcode != KNOT_RCODE_FORMERR &&
qdata->rcode != KNOT_RCODE_NOTAUTH) {
AXFROUT_LOG(LOG_ERR, qdata, "failed to start (%s)",
knot_strerror(ret));
}
return KNOT_STATE_FAIL;
} else {
AXFROUT_LOG(LOG_INFO, qdata, "started, serial %u",
......
......@@ -316,8 +316,11 @@ int ixfr_process_query(knot_pkt_t *pkt, knotd_qdata_t *qdata)
qdata->type = KNOTD_QUERY_TYPE_AXFR; /* Solve as AXFR. */
return axfr_process_query(pkt, qdata);
default: /* Server errors. */
IXFROUT_LOG(LOG_ERR, qdata, "failed to start (%s)",
knot_strerror(ret));
if (qdata->rcode != KNOT_RCODE_FORMERR &&
qdata->rcode != KNOT_RCODE_NOTAUTH) {
IXFROUT_LOG(LOG_ERR, qdata, "failed to start (%s)",
knot_strerror(ret));
}
return KNOT_STATE_FAIL;
}
}
......
......@@ -53,8 +53,6 @@ int notify_process_query(knot_pkt_t *pkt, knotd_qdata_t *qdata)
if (state == KNOT_STATE_FAIL) {
switch (qdata->rcode) {
case KNOT_RCODE_NOTAUTH: /* Not authoritative or ACL check failed. */
NOTIFY_IN_LOG(LOG_NOTICE, qdata, "unauthorized request");
break;
case KNOT_RCODE_FORMERR: /* Silently ignore bad queries. */
default:
break;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment