zone-update.c 18.3 KB
Newer Older
1
/*  Copyright (C) 2016 CZ.NIC, z.s.p.o. <knot-dns@labs.nic.cz>
2 3 4 5 6 7 8 9 10 11 12 13 14 15 16

    This program is free software: you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation, either version 3 of the License, or
    (at your option) any later version.

    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU General Public License for more details.

    You should have received a copy of the GNU General Public License
    along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */

17
#include "knot/common/log.h"
18
#include "knot/dnssec/zone-events.h"
Daniel Salzman's avatar
Daniel Salzman committed
19
#include "knot/updates/zone-update.h"
20
#include "knot/zone/serial.h"
21
#include "contrib/mempattern.h"
22
#include "contrib/ucw/lists.h"
23
#include "contrib/ucw/mempool.h"
24

25 26
#include <urcu.h>

27 28
static int init_incremental(zone_update_t *update, zone_t *zone)
{
29 30 31
	if (zone->contents == NULL) {
		return KNOT_EINVAL;
	}
32

33 34 35 36
	int ret = changeset_init(&update->change, zone->name);
	if (ret != KNOT_EOK) {
		return ret;
	}
37

38 39 40 41 42 43
	ret = apply_prepare_zone_copy(zone->contents, &update->new_cont);
	if (ret != KNOT_EOK) {
		changeset_clear(&update->change);
		return ret;
	}

44
	apply_init_ctx(&update->a_ctx, update->new_cont, 0);
45

46
	/* Copy base SOA RR. */
47 48 49
	update->change.soa_from =
		node_create_rrset(update->zone->contents->apex, KNOT_RRTYPE_SOA);
	if (update->change.soa_from == NULL) {
50 51
		changeset_clear(&update->change);
		zone_contents_free(&update->new_cont);
52 53
		return KNOT_ENOMEM;
	}
54 55 56 57 58 59 60 61 62 63 64

	return KNOT_EOK;
}

static int init_full(zone_update_t *update, zone_t *zone)
{
	update->new_cont = zone_contents_new(zone->name);
	if (update->new_cont == NULL) {
		return KNOT_ENOMEM;
	}

65 66
	apply_init_ctx(&update->a_ctx, update->new_cont, 0);

67 68 69
	return KNOT_EOK;
}

70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98
/* ------------------------------- API -------------------------------------- */

int zone_update_init(zone_update_t *update, zone_t *zone, zone_update_flags_t flags)
{
	if (update == NULL || zone == NULL) {
		return KNOT_EINVAL;
	}

	memset(update, 0, sizeof(*update));
	update->zone = zone;

	mm_ctx_mempool(&update->mm, MM_DEFAULT_BLKSIZE);
	update->flags = flags;

	if (flags & UPDATE_INCREMENTAL) {
		return init_incremental(update, zone);
	} else if (flags & UPDATE_FULL) {
		return init_full(update, zone);
	} else {
		return KNOT_EINVAL;
	}
}

const zone_node_t *zone_update_get_node(zone_update_t *update, const knot_dname_t *dname)
{
	if (update == NULL || dname == NULL) {
		return NULL;
	}

99
	return zone_contents_find_node(update->new_cont, dname);
100 101
}

102 103
const zone_node_t *zone_update_get_apex(zone_update_t *update)
{
104 105 106 107
	if (update == NULL) {
		return NULL;
	}

108 109 110 111 112 113 114 115 116 117 118 119 120 121 122
	return zone_update_get_node(update, update->zone->name);
}

uint32_t zone_update_current_serial(zone_update_t *update)
{
	const zone_node_t *apex = zone_update_get_apex(update);
	if (apex) {
		return knot_soa_serial(node_rdataset(apex, KNOT_RRTYPE_SOA));
	} else {
		return 0;
	}
}

const knot_rdataset_t *zone_update_from(zone_update_t *update)
{
123 124 125 126
	if (update == NULL) {
		return NULL;
	}

127 128 129 130 131 132
	if (update->flags & UPDATE_INCREMENTAL) {
		const zone_node_t *apex = update->zone->contents->apex;
		return node_rdataset(apex, KNOT_RRTYPE_SOA);
	}

	return NULL;
133 134 135 136
}

const knot_rdataset_t *zone_update_to(zone_update_t *update)
{
137 138 139
	if (update == NULL) {
		return NULL;
	}
140

141 142 143 144 145 146 147 148
	if (update->flags & UPDATE_FULL) {
		const zone_node_t *apex = update->new_cont->apex;
		return node_rdataset(apex, KNOT_RRTYPE_SOA);
	} else if (update->flags & UPDATE_INCREMENTAL) {
		if (update->change.soa_to == NULL) {
			return NULL;
		}
		return &update->change.soa_to->rrs;
149 150
	}

151
	return NULL;
152 153
}

154 155
void zone_update_clear(zone_update_t *update)
{
156 157
	if (update == NULL) {
		return;
158
	}
159 160 161 162

	if (update->flags & UPDATE_INCREMENTAL) {
		/* Revert any changes on error, do nothing on success. */
		update_rollback(&update->a_ctx);
163
		update_free_zone(&update->new_cont);
164 165 166 167 168 169
		changeset_clear(&update->change);
	} else if (update->flags & UPDATE_FULL) {
		zone_contents_deep_free(&update->new_cont);
	}
	mp_delete(update->mm.ctx);
	memset(update, 0, sizeof(*update));
170
}
171

172 173
int zone_update_add(zone_update_t *update, const knot_rrset_t *rrset)
{
174 175 176 177
	if (update == NULL) {
		return KNOT_EINVAL;
	}

178
	if (update->flags & UPDATE_INCREMENTAL) {
179 180 181 182 183 184 185
		int ret = changeset_add_addition(&update->change, rrset, CHANGESET_CHECK);
		if (ret != KNOT_EOK) {
			return ret;
		}

		if (rrset->type == KNOT_RRTYPE_SOA) {
			/* replace previous SOA */
186
			ret = apply_replace_soa(&update->a_ctx, &update->change);
187 188 189 190 191 192
			if (ret != KNOT_EOK) {
				changeset_remove_addition(&update->change, rrset);
			}
			return ret;
		}

193
		ret = apply_add_rr(&update->a_ctx, rrset);
194 195 196 197 198 199
		if (ret != KNOT_EOK) {
			changeset_remove_addition(&update->change, rrset);
			return ret;
		}

		return KNOT_EOK;
200 201 202 203 204 205 206 207 208 209
	} else if (update->flags & UPDATE_FULL) {
		zone_node_t *n = NULL;
		return zone_contents_add_rr(update->new_cont, rrset, &n);
	} else {
		return KNOT_EINVAL;
	}
}

int zone_update_remove(zone_update_t *update, const knot_rrset_t *rrset)
{
210 211 212 213
	if (update == NULL) {
		return KNOT_EINVAL;
	}

214
	if (update->flags & UPDATE_INCREMENTAL) {
215 216 217 218 219 220 221 222 223 224
		int ret = changeset_add_removal(&update->change, rrset, CHANGESET_CHECK);
		if (ret != KNOT_EOK) {
			return ret;
		}

		if (rrset->type == KNOT_RRTYPE_SOA) {
			/* SOA is replaced with addition */
			return KNOT_EOK;
		}

225
		ret = apply_remove_rr(&update->a_ctx, rrset);
226 227 228 229 230 231
		if (ret != KNOT_EOK) {
			changeset_remove_removal(&update->change, rrset);
			return ret;
		}

		return KNOT_EOK;
232 233
	} else if (update->flags & UPDATE_FULL) {
		zone_node_t *n = NULL;
234 235 236 237
		knot_rrset_t *rrs_copy = knot_rrset_copy(rrset, &update->mm);
		int ret = zone_contents_remove_rr(update->new_cont, rrs_copy, &n);
		knot_rrset_free(&rrs_copy, &update->mm);
		return ret;
238
	} else {
239
		return KNOT_EINVAL;
240 241 242
	}
}

243 244 245 246 247 248 249 250
int zone_update_remove_rrset(zone_update_t *update, knot_dname_t *owner, uint16_t type)
{
	if (update == NULL || owner == NULL) {
		return KNOT_EINVAL;
	}

	if (update->flags & UPDATE_INCREMENTAL) {
		/* Remove the RRSet from the original node */
251
		const zone_node_t *node = zone_contents_find_node(update->new_cont, owner);
252 253
		if (node != NULL) {
			knot_rrset_t rrset = node_rrset(node, type);
Daniel Salzman's avatar
Daniel Salzman committed
254 255
			int ret = changeset_add_removal(&update->change, &rrset,
			                                CHANGESET_CHECK);
256 257 258 259
			if (ret != KNOT_EOK) {
				return ret;
			}

260 261 262 263 264
			if (type == KNOT_RRTYPE_SOA) {
				/* SOA is replaced with addition */
				return KNOT_EOK;
			}

265
			ret = apply_remove_rr(&update->a_ctx, &rrset);
266 267 268
			if (ret != KNOT_EOK) {
				return ret;
			}
269
		} else {
270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295
			return KNOT_ENONODE;
		}
	} else if (update->flags & UPDATE_FULL) {
		/* Remove the RRSet from the non-synthesized new node */
		const zone_node_t *node = zone_contents_find_node(update->new_cont, owner);
		if (node == NULL) {
			return KNOT_ENONODE;
		}

		knot_rrset_t rrset = node_rrset(node, type);
		int ret = zone_update_remove(update, &rrset);
		if (ret != KNOT_EOK) {
			return ret;
		}
	}

	return KNOT_EOK;
}

int zone_update_remove_node(zone_update_t *update, const knot_dname_t *owner)
{
	if (update == NULL || owner == NULL) {
		return KNOT_EINVAL;
	}

	if (update->flags & UPDATE_INCREMENTAL) {
296 297
		/* Remove all RRSets from the new node */
		const zone_node_t *node = zone_contents_find_node(update->new_cont, owner);
298 299 300 301
		if (node != NULL) {
			size_t rrset_count = node->rrset_count;
			for (int i = 0; i < rrset_count; ++i) {
				knot_rrset_t rrset = node_rrset_at(node, rrset_count - 1 - i);
Daniel Salzman's avatar
Daniel Salzman committed
302 303
				int ret = changeset_add_removal(&update->change, &rrset,
				                                CHANGESET_CHECK);
304 305 306 307
				if (ret != KNOT_EOK) {
					return ret;
				}

308 309 310 311 312
				if (rrset.type == KNOT_RRTYPE_SOA) {
					/* SOA is replaced with addition */
					return KNOT_EOK;
				}

313
				ret = apply_remove_rr(&update->a_ctx, &rrset);
314 315 316 317
				if (ret != KNOT_EOK) {
					return ret;
				}
			}
318
		} else {
319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340
			return KNOT_ENONODE;
		}
	} else if (update->flags & UPDATE_FULL) {
		/* Remove all RRSets from the non-synthesized new node */
		const zone_node_t *node = zone_contents_find_node(update->new_cont, owner);
		if (node == NULL) {
			return KNOT_ENONODE;
		}

		size_t rrset_count = node->rrset_count;
		for (int i = 0; i < rrset_count; ++i) {
			knot_rrset_t rrset = node_rrset_at(node, rrset_count - 1 - i);
			int ret = zone_update_remove(update, &rrset);
			if (ret != KNOT_EOK) {
				return ret;
			}
		}
	}

	return KNOT_EOK;
}

341 342 343 344
static bool apex_rr_changed(const zone_node_t *old_apex,
                            const zone_node_t *new_apex,
                            uint16_t type)
{
345 346
	assert(old_apex);
	assert(new_apex);
347 348 349 350 351 352
	knot_rrset_t old_rr = node_rrset(old_apex, type);
	knot_rrset_t new_rr = node_rrset(new_apex, type);

	return !knot_rrset_equal(&old_rr, &new_rr, KNOT_RRSET_COMPARE_WHOLE);
}

353
static bool apex_dnssec_changed(zone_update_t *update)
354 355
{
	const zone_node_t *new_apex = zone_update_get_apex(update);
356 357 358 359 360 361 362 363 364 365
	if (update->zone->contents != NULL) {
		const zone_node_t *old_apex = update->zone->contents->apex;
		return !changeset_empty(&update->change) &&
		       (apex_rr_changed(new_apex, old_apex, KNOT_RRTYPE_DNSKEY) ||
		        apex_rr_changed(new_apex, old_apex, KNOT_RRTYPE_NSEC3PARAM));
	} else if (new_apex != NULL) {
		return true;
	}

	return false;
366 367 368
}

static int sign_update(zone_update_t *update,
369
                       zone_contents_t *new_contents)
370
{
371 372
	assert(update);
	assert(new_contents);
373

374 375
	/* Check if the UPDATE changed DNSKEYs or NSEC3PARAM.
	 * If so, we have to sign the whole zone. */
376 377
	int ret = KNOT_EOK;
	uint32_t refresh_at = 0;
378 379 380 381 382 383
	changeset_t sec_ch;
	ret = changeset_init(&sec_ch, update->zone->name);
	if (ret != KNOT_EOK) {
		return ret;
	}

384
	const bool full_sign = changeset_empty(&update->change) ||
385
	                       apex_dnssec_changed(update);
386
	if (full_sign) {
387
		ret = knot_dnssec_zone_sign(new_contents, &sec_ch,
388 389 390
		                            ZONE_SIGN_KEEP_SOA_SERIAL,
		                            &refresh_at);
	} else {
391
		/* Sign the created changeset */
392
		ret = knot_dnssec_sign_changeset(new_contents, &update->change,
393
		                                 &sec_ch, &refresh_at);
394 395
	}
	if (ret != KNOT_EOK) {
396
		changeset_clear(&sec_ch);
397 398 399
		return ret;
	}

400
	/* Apply DNSSEC changeset */
401
	ret = apply_changeset_directly(&update->a_ctx, &sec_ch);
402
	if (ret != KNOT_EOK) {
403
		changeset_clear(&sec_ch);
404 405 406
		return ret;
	}

407
	if (!full_sign) {
408
		/* Merge changesets */
409 410 411 412 413 414
		ret = changeset_merge(&update->change, &sec_ch);
		if (ret != KNOT_EOK) {
			update_rollback(&update->a_ctx);
			changeset_clear(&sec_ch);
			return ret;
		}
415 416
	}

417
	/* Plan next zone resign. */
418 419 420 421 422
	const time_t resign_time = zone_events_get_time(update->zone, ZONE_EVENT_DNSSEC);
	if (refresh_at < resign_time) {
		zone_events_schedule_at(update->zone, ZONE_EVENT_DNSSEC, refresh_at);
	}

423 424
	/* We are not calling update_cleanup, as the rollback data are merged
	 * into the main changeset and will get cleaned up with that. */
425 426
	changeset_clear(&sec_ch);

427 428 429
	return KNOT_EOK;
}

430
static int set_new_soa(zone_update_t *update, unsigned serial_policy)
431
{
432 433
	assert(update);

Daniel Salzman's avatar
Daniel Salzman committed
434 435
	knot_rrset_t *soa_cpy = node_create_rrset(zone_update_get_apex(update),
	                                          KNOT_RRTYPE_SOA);
436 437 438 439 440
	if (soa_cpy == NULL) {
		return KNOT_ENOMEM;
	}

	uint32_t old_serial = knot_soa_serial(&soa_cpy->rrs);
441
	uint32_t new_serial = serial_next(old_serial, serial_policy);
442 443 444 445 446 447 448 449 450 451 452 453
	if (serial_compare(old_serial, new_serial) >= 0) {
		log_zone_warning(update->zone->name, "updated serial is lower "
		                 "than current, serial %u -> %u",
		                  old_serial, new_serial);
	}

	knot_soa_serial_set(&soa_cpy->rrs, new_serial);
	update->change.soa_to = soa_cpy;

	return KNOT_EOK;
}

Daniel Salzman's avatar
Daniel Salzman committed
454 455
static int commit_incremental(conf_t *conf, zone_update_t *update,
                              zone_contents_t **contents_out)
456
{
457
	assert(update);
458
	assert(contents_out);
459

460 461 462 463 464
	if (changeset_empty(&update->change)) {
		changeset_clear(&update->change);
		return KNOT_EOK;
	}

465
	zone_contents_t *new_contents = update->new_cont;
466
	int ret = KNOT_EOK;
467
	if (zone_update_to(update) == NULL) {
468
		/* No SOA in the update, create one according to the current policy */
469 470
		conf_val_t val = conf_zone_get(conf, C_SERIAL_POLICY, update->zone->name);
		ret = set_new_soa(update, conf_opt(&val));
471
		if (ret != KNOT_EOK) {
472 473 474
			update_rollback(&update->a_ctx);
			update_free_zone(&new_contents);
			changeset_clear(&update->change);
475 476 477
			return ret;
		}

478
		ret = apply_replace_soa(&update->a_ctx, &update->change);
479 480 481 482 483 484
		if (ret != KNOT_EOK) {
			update_rollback(&update->a_ctx);
			update_free_zone(&new_contents);
			changeset_clear(&update->change);
			return ret;
		}
485
	}
486

487
	conf_val_t val = conf_zone_get(conf, C_DNSSEC_SIGNING, update->zone->name);
488
	bool dnssec_enable = (update->flags & UPDATE_SIGN) && conf_bool(&val);
489

490
	/* Sign the update. */
491
	if (dnssec_enable) {
492 493 494 495 496 497 498 499
		ret = apply_prepare_to_sign(&update->a_ctx);
		if (ret != KNOT_EOK) {
			update_rollback(&update->a_ctx);
			update_free_zone(&new_contents);
			changeset_clear(&update->change);
			return ret;
		}

500
		ret = sign_update(update, new_contents);
501
		if (ret != KNOT_EOK) {
502
			update_rollback(&update->a_ctx);
503
			update_free_zone(&new_contents);
504
			changeset_clear(&update->change);
505 506
			return ret;
		}
507
	} else {
508 509 510 511 512 513 514
		ret = apply_finalize(&update->a_ctx);
		if (ret != KNOT_EOK) {
			update_rollback(&update->a_ctx);
			update_free_zone(&new_contents);
			changeset_clear(&update->change);
			return ret;
		}
515
	}
516

517
	/* Write changes to journal if all went well. (DNSSEC merged) */
518
	ret = zone_change_store(conf, update->zone, &update->change);
519
	if (ret != KNOT_EOK) {
520
		update_rollback(&update->a_ctx);
521 522 523
		update_free_zone(&new_contents);
		return ret;
	}
524

525 526
	*contents_out = new_contents;

527 528 529
	return KNOT_EOK;
}

530 531
static int commit_full(conf_t *conf, zone_update_t *update, zone_contents_t **contents_out)
{
532 533 534 535 536 537 538 539 540
	assert(update);
	assert(contents_out);

	/* Check if we have SOA. We might consider adding full semantic check here.
	 * But if we wanted full sem-check I'd consider being it controlled by a flag
	 * - to enable/disable it on demand. */
	if (!node_rrtype_exists(update->new_cont->apex, KNOT_RRTYPE_SOA)) {
		return KNOT_ESEMCHECK;
	}
541 542 543 544

	zone_contents_adjust_full(update->new_cont);

	conf_val_t val = conf_zone_get(conf, C_DNSSEC_SIGNING, update->zone->name);
545
	bool dnssec_enable = (update->flags & UPDATE_SIGN) && conf_bool(&val);
546

547
	/* Sign the update. */
548
	if (dnssec_enable) {
549
		int ret = sign_update(update, update->new_cont);
550 551 552 553 554 555 556 557 558 559 560
		if (ret != KNOT_EOK) {
			update_rollback(&update->a_ctx);
			return ret;
		}
	}

	update_cleanup(&update->a_ctx);
	*contents_out = update->new_cont;
	return KNOT_EOK;
}

561
int zone_update_commit(conf_t *conf, zone_update_t *update)
562
{
563
	if (conf == NULL || update == NULL) {
564 565 566 567 568
		return KNOT_EINVAL;
	}

	int ret = KNOT_EOK;
	zone_contents_t *new_contents = NULL;
569
	if (update->flags & UPDATE_INCREMENTAL) {
570 571 572 573 574
		ret = commit_incremental(conf, update, &new_contents);
		if (ret != KNOT_EOK) {
			return ret;
		}
	} else {
575 576 577 578
		ret = commit_full(conf, update, &new_contents);
		if (ret != KNOT_EOK) {
			return ret;
		}
579 580
	}

581 582 583 584 585 586 587
	conf_val_t val = conf_zone_get(conf, C_MAX_ZONE_SIZE, update->zone->name);
	int64_t size_limit = conf_int(&val);

	if (new_contents != NULL && new_contents->size > size_limit) {
		return KNOT_EZONESIZE;
	}

588
	/* If there is anything to change */
589
	if (new_contents != NULL) {
590
		/* Switch zone contents. */
Daniel Salzman's avatar
Daniel Salzman committed
591 592
		zone_contents_t *old_contents = zone_switch_contents(update->zone,
		                                                     new_contents);
593 594 595

		/* Sync RCU. */
		synchronize_rcu();
596
		if (update->flags & UPDATE_FULL) {
597
			zone_contents_deep_free(&old_contents);
598 599
			update->new_cont = NULL;
		} else if (update->flags & UPDATE_INCREMENTAL) {
600 601
			update_cleanup(&update->a_ctx);
			update_free_zone(&old_contents);
602
			update->new_cont = NULL;
603 604 605 606 607
			changeset_clear(&update->change);
		}
	}

	return KNOT_EOK;
608 609
}

610 611 612 613 614 615
static int iter_init_tree_iters(zone_update_iter_t *it, zone_update_t *update,
                                bool nsec3)
{
	zone_tree_t *tree;

	/* Set zone iterator. */
616
	zone_contents_t *_contents = update->new_cont;
617 618 619 620

	/* Begin iteration. We can safely assume _contents is a valid pointer. */
	tree = nsec3 ? _contents->nsec3_nodes : _contents->nodes;
	hattrie_build_index(tree);
621 622
	it->tree_it = hattrie_iter_begin(nsec3 ? _contents->nsec3_nodes : _contents->nodes, true);
	if (it->tree_it == NULL) {
623 624 625
		return KNOT_ENOMEM;
	}

626 627
	it->cur_node = (zone_node_t *)(*hattrie_iter_val(it->tree_it));

628 629 630
	return KNOT_EOK;
}

631
static int iter_get_next_node(zone_update_iter_t *it)
632
{
633 634 635 636 637
	hattrie_iter_next(it->tree_it);
	if (hattrie_iter_finished(it->tree_it)) {
		hattrie_iter_free(it->tree_it);
		it->tree_it = NULL;
		it->cur_node = NULL;
638 639 640
		return KNOT_ENOENT;
	}

641
	it->cur_node = (zone_node_t *)(*hattrie_iter_val(it->tree_it));
642 643 644 645 646 647 648 649 650 651 652 653 654 655 656

	return KNOT_EOK;
}

static int iter_init(zone_update_iter_t *it, zone_update_t *update, const bool nsec3)
{
	memset(it, 0, sizeof(*it));

	it->update = update;
	it->nsec3 = nsec3;
	int ret = iter_init_tree_iters(it, update, nsec3);
	if (ret != KNOT_EOK) {
		return ret;
	}

657
	it->cur_node = (zone_node_t *)(*hattrie_iter_val(it->tree_it));
658 659 660 661 662 663

	return KNOT_EOK;
}

int zone_update_iter(zone_update_iter_t *it, zone_update_t *update)
{
664 665 666 667
	if (it == NULL || update == NULL) {
		return KNOT_EINVAL;
	}

668 669 670 671 672
	return iter_init(it, update, false);
}

int zone_update_iter_nsec3(zone_update_iter_t *it, zone_update_t *update)
{
673 674 675 676
	if (it == NULL || update == NULL) {
		return KNOT_EINVAL;
	}

677 678
	if (update->flags & UPDATE_FULL) {
		if (update->new_cont->nsec3_nodes == NULL) {
679
			/* No NSEC3 tree. */
680 681 682 683 684
			return KNOT_ENOENT;
		}
	} else {
		if (update->change.add->nsec3_nodes == NULL &&
		    update->change.remove->nsec3_nodes == NULL) {
685
			/* No NSEC3 changes. */
686 687 688 689 690 691 692 693 694 695 696 697 698
			return KNOT_ENOENT;
		}
	}

	return iter_init(it, update, true);
}

int zone_update_iter_next(zone_update_iter_t *it)
{
	if (it == NULL) {
		return KNOT_EINVAL;
	}

699 700
	if (it->tree_it != NULL) {
		int ret = iter_get_next_node(it);
701 702 703 704 705 706 707 708 709 710
		if (ret != KNOT_EOK && ret != KNOT_ENOENT) {
			return ret;
		}
	}

	return KNOT_EOK;
}

const zone_node_t *zone_update_iter_val(zone_update_iter_t *it)
{
711
	if (it != NULL) {
712
		return it->cur_node;
713 714 715 716 717
	} else {
		return NULL;
	}
}

718
void zone_update_iter_finish(zone_update_iter_t *it)
719
{
720
	if (it == NULL) {
721
		return;
722 723
	}

724
	hattrie_iter_free(it->tree_it);
725 726
}

727
bool zone_update_no_change(zone_update_t *update)
728
{
729 730 731 732
	if (update == NULL) {
		return true;
	}

733 734 735
	if (update->flags & UPDATE_INCREMENTAL) {
		return changeset_empty(&update->change);
	} else {
736 737 738
		/* This branch does not make much sense and FULL update will most likely
		 * be a change every time anyway, just return false. */
		return false;
739
	}
740
}