1. 09 Jan, 2019 1 commit
  2. 11 Dec, 2018 3 commits
  3. 03 Dec, 2018 1 commit
    • Vladimír Čunát's avatar
      lib/utils: fix memory leak since 58def8bb · 021cdc24
      Vladimír Čunát authored
      The problem was the mm_malloc() typo :-/ so allocation was going through
      malloc() instead of the packet's allocator (always memory pool ATM).
      I added mm_free() for better correctness anyway.
      021cdc24
  4. 26 Nov, 2018 3 commits
  5. 21 Nov, 2018 1 commit
  6. 14 Sep, 2018 1 commit
    • Marek Vavruša's avatar
      daemon/worker: fixes error handling from TLS writes · f52231b6
      Marek Vavruša authored
      The error handling loop for uncorking TLS data was wrong, as the
      underlying push function is asynchronous and there's no relationship
      between completed DNS packet writes and number of TLS message writes.
      In case of the asynchronous function, the buffered data must be valid
      until the write is complete, currently this is not guaranteed and
      loading the resolver with pipelined requests results in memory errors:
      
      ```
      $ getdns_query @127.0.0.1#853 -s -a -s -l L -B -F queries -q
      ...
      ==47111==ERROR: AddressSanitizer: heap-use-after-free on address 0x6290040a1253 at pc 0x00010da960d3 bp 0x7ffee2628b30 sp 0x7ffee26282e0
      READ of size 499 at 0x6290040a1253 thread T0
          #0 0x10da960d2 in wrap_write (libclang_rt.asan_osx_dynamic.dylib:x86_64h+0x1f0d2)
          #1 0x10d855971 in uv__write (libuv.1.dylib:x86_64+0xf971)
          #2 0x10d85422e in uv__stream_io (libuv.1.dylib:x86_64+0xe22e)
          #3 0x10d85b35a in uv__io_poll (libuv.1.dylib:x86_64+0x1535a)
          #4 0x10d84c644 in uv_run (libuv.1.dylib:x86_64+0x6644)
          #5 0x10d602ddf in main main.c:422
          #6 0x7fff6a28a014 in start (libdyld.dylib:x86_64+0x1014)
      
      0x6290040a1253 is located 83 bytes inside of 16895-byte region [0x6290040a1200,0x6290040a53ff)
      freed by thread T0 here:
          #0 0x10dacdfdd in wrap_free (libclang_rt.asan_osx_dynamic.dylib:x86_64h+0x56fdd)
          #1 0x10d913c2e in _mbuffer_head_remove_bytes (libgnutls.30.dylib:x86_64+0xbc2e)
          #2 0x10d915080 in _gnutls_io_write_flush (libgnutls.30.dylib:x86_64+0xd080)
          #3 0x10d90ca18 in _gnutls_send_tlen_int (libgnutls.30.dylib:x86_64+0x4a18)
          #4 0x10d90edde in gnutls_record_send2 (libgnutls.30.dylib:x86_64+0x6dde)
          #5 0x10d90f085 in gnutls_record_uncork (libgnutls.30.dylib:x86_64+0x7085)
          #6 0x10d5f6569 in tls_push tls.c:238
          #7 0x10d5e5b2a in qr_task_send worker.c:1002
          #8 0x10d5e2ea6 in qr_task_finalize worker.c:1562
          #9 0x10d5dab99 in qr_task_step worker.c
          #10 0x10d5e12fe in worker_process_tcp worker.c:2410
      ```
      
      The current implementation adds opportunistic uv_try_write which
      either writes the requested data, or returns UV_EAGAIN or an error,
      which then falls back to slower asynchronous write that copies the buffered data.
      
      The function signature is changed from simple write to vectorized write.
      
      This also enables TLS False Start to save 1RTT when possible.
      f52231b6
  7. 14 Aug, 2018 4 commits
  8. 11 May, 2018 1 commit
  9. 09 May, 2018 2 commits
  10. 23 Apr, 2018 1 commit
    • Marek Vavrusa's avatar
      lib/utils: fixed memory corruption in kr_pkt_recycle and kr_pkt_clear_payload · c4037c24
      Marek Vavrusa authored
      Previous implementation forgot to clear the compression table, which is
      an internal structure to packet. So when a recycled packet was reused,
      it compared owners of newly inserted records with dangling pointers left
      in the compression table.
      
      This is less of a problem in query processing,
      as each packet uses a memory pool, so the pointed names were never deallocated,
      but it would write out wrong compression pointers because the compression
      table kept pointing into packet that was now cleared and reused for something else.
      
      It is more of a problem with packets created without a memory pool,
      as the compression table kept references to memory that was already freed.
      c4037c24
  11. 18 Apr, 2018 2 commits
  12. 12 Apr, 2018 1 commit
  13. 01 Mar, 2018 1 commit
  14. 15 Feb, 2018 1 commit
  15. 29 Jan, 2018 1 commit
  16. 23 Jan, 2018 1 commit
    • Vladimír Čunát's avatar
      nitpicks from review of !405: query-trace · f705c82a
      Vladimír Čunát authored
      The deckard change was probably unintentional, so I reverted that.
      The only real mistake I found was `sizeof(128)`, though the effect was
      just unnecessary reallocations.
      
      On the whole I really like it.  Verbose logging might get slightly
      slower, due to increased amount of string allocation and copying,
      but it does seem worth it, at least until we can prove otherwise.
      I didn't look much into http module changes, etc.
      f705c82a
  17. 18 Jan, 2018 1 commit
  18. 17 Jan, 2018 1 commit
  19. 12 Jan, 2018 1 commit
  20. 08 Jan, 2018 1 commit
  21. 02 Jan, 2018 1 commit
  22. 21 Dec, 2017 2 commits
    • Marek Vavruša's avatar
      lib: added support for trace_log for verbose messages · 393b738a
      Marek Vavruša authored
      The `QRVERBOSE` macro uses the `query` pointer to find out whether the
      request has trace log enabled. If it does, it uses trace log to log verbose messages using that callback (regardless of whether verbose mode is set or not).
      
      This required changing of structure printing functions to formatting functions returning textual representation of the objects (dname, rrset, pkt).
      This is potentially slower as creates heap objects, but it doesn't happen
      in the hotpath so it doesn't really matter for verbose logs.
      393b738a
    • Marek Vavruša's avatar
      lib/resolve: add support for per-request logging · 0a04428e
      Marek Vavruša authored
      This is useful in many troubleshooting scenarios when you want debug logs
      just for a single request. It's going to expand on TRACE flag functionality
      in the next PRs, so that special requests can be invoked with various tracers attached.
      
      Currently this is only available in the C modules that can set the callback,
      it's not called anywhere in the library yet.
      0a04428e
  23. 08 Dec, 2017 1 commit
    • Vitezslav Kriz's avatar
      use monotonic time · 0abbe1f4
      Vitezslav Kriz authored
      Monotonic time from libuv function uv_now (wrapped in kr_now) is
      used for query timeout, stats and RTT in reputation cache.
      
      Cache, DNSSEC Validation and Cookies use real time.
      0abbe1f4
  24. 20 Nov, 2017 1 commit
  25. 16 Nov, 2017 1 commit
  26. 15 Nov, 2017 1 commit
  27. 26 Oct, 2017 1 commit
  28. 23 Oct, 2017 1 commit
  29. 20 Oct, 2017 1 commit
    • Vladimír Čunát's avatar
      . · e00d6c1a
      Vladimír Čunát authored
      Root zone features seem usable now.
      e00d6c1a
  30. 18 Oct, 2017 1 commit