From e1400c42e8a951a9a354c3196ec3f7e0a6686258 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vladim=C3=ADr=20=C4=8Cun=C3=A1t?= Date: Tue, 13 Feb 2018 14:57:22 +0100 Subject: [PATCH] stats module: fix stats.list() returning nothing I messed this up in 44c2ea6bb0 !465. --- NEWS | 1 + modules/stats/stats.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 8fb5cc63..90056c18 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ - detect_time_jump module: don't clear cache on suspend-resume (#284) +- stats module: fix stats.list() returning nothing, regressed in 2.0.0 Knot Resolver 2.0.0 (2018-01-31) diff --git a/modules/stats/stats.c b/modules/stats/stats.c index 52517542..f0a517f8 100644 --- a/modules/stats/stats.c +++ b/modules/stats/stats.c @@ -313,7 +313,7 @@ static char* stats_list(void *env, struct kr_module *module, const char *args) size_t args_len = args ? strlen(args) : 0; for (unsigned i = 0; i < metric_const_end; ++i) { struct const_metric_elm *elm = &const_metrics[i]; - if (args && strncmp(elm->key, args, args_len) == 0) { + if (!args || strncmp(elm->key, args, args_len) == 0) { json_append_member(root, elm->key, json_mknumber(elm->val)); } } -- 2.22.0