Commit 6a471e72 authored by Petr Špaček's avatar Petr Špaček

ta_sentinel: fix is/not logic

I got confused by the original text in
draft-ietf-dnsop-kskroll-sentinel-00 and inverted meaning of is/not
sentinel queries.
parent 0e9b529b
......@@ -4,6 +4,8 @@ Knot Resolver 2.X.Y (2018-0M-DD)
Incompatible changes
--------------------
- systemd: more chages in default unit files (TODO)
- ta_sentinel: implement protocol draft-ietf-dnsop-kskroll-sentinel-01
(our draft-ietf-dnsop-kskroll-sentinel-00 implementation had inverted logic)
Bugfixes
--------
......
......@@ -52,8 +52,8 @@ function M.layer.finish(state, req, pkt)
end
end
if (found and sentype == 'is')
or (not found and sentype == 'not') then
if (sentype == 'is' and not found) -- expected key is not there
or (sentype == 'not' and found) then -- unexpected key is there
kpkt:clear_payload()
kpkt:rcode(2)
kpkt:ad(false)
......
Subproject commit dd660f91a4ea5d39e5a7fead340ed37b193de095
Subproject commit 9c7c6313552892913fd6e3e13d295c166b1c0623
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment